Skip to content

[SDK] Change "pay with a debit card" to "pay with card" #6891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

[SDK] Change "pay with a debit card" to "pay with card" #6891

merged 1 commit into from
Apr 29, 2025

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Apr 29, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on rewording text related to payment options in the thirdweb application, specifically changing instances of "debit card" to "card" for clarity and conciseness.

Detailed summary

  • Updated text in TransactionModeScreen.tsx: changed "pay with a debit card" to "pay with card."
  • Updated text in SwapScreenContent.tsx: changed "pay with a debit card" to "pay with card."
  • Updated text in TokenSelectorScreen.tsx: changed "Pay with a debit card" to "Pay with card."
  • Updated text in FiatScreenContent.tsx: changed "Pay with a debit card" to "Pay with card."
  • Updated error message in errors.ts: changed "pay with a debit card" to "pay with card."

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Apr 29, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2025 9:05pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2025 9:05pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2025 9:05pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2025 9:05pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2025 9:05pm

@changeset-bot
Copy link

changeset-bot bot commented Apr 29, 2025

🦋 Changeset detected

Latest commit: fabfe47

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Apr 29, 2025
@joaquim-verges joaquim-verges changed the title [PayEmbed] Change "pay with a debit card" to "pay with card" [SDK] Change "pay with a debit card" to "pay with card" Apr 29, 2025
@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Apr 29, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges marked this pull request as ready for review April 29, 2025 20:57
@joaquim-verges joaquim-verges requested review from a team as code owners April 29, 2025 20:57
@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 51.19 KB (0%) 1.1 s (0%) 127 ms (+300.23% 🔺) 1.2 s
thirdweb (cjs) 143.86 KB (0%) 2.9 s (0%) 206 ms (+120.6% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 5.67 KB (0%) 114 ms (0%) 66 ms (+2790.2% 🔺) 180 ms
thirdweb/chains (tree-shaking) 514 B (0%) 11 ms (0%) 18 ms (+1519.14% 🔺) 28 ms
thirdweb/react (minimal + tree-shaking) 19.38 KB (0%) 388 ms (0%) 86 ms (+1184.64% 🔺) 474 ms

@codecov
Copy link

codecov bot commented Apr 29, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.21%. Comparing base (e03b622) to head (fabfe47).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nnectWallet/screens/Buy/fiat/FiatScreenContent.tsx 0.00% 1 Missing ⚠️
packages/thirdweb/src/react/web/utils/errors.ts 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6891      +/-   ##
==========================================
- Coverage   55.22%   55.21%   -0.01%     
==========================================
  Files         896      896              
  Lines       57057    57057              
  Branches     3958     3955       -3     
==========================================
- Hits        31510    31506       -4     
- Misses      25450    25454       +4     
  Partials       97       97
Flag Coverage Δ
packages 55.21% <0.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
...onnectWallet/screens/Buy/TransactionModeScreen.tsx 8.98% <ø> (ø)
...nnectWallet/screens/Buy/swap/SwapScreenContent.tsx 7.59% <ø> (ø)
...ectWallet/screens/Buy/swap/TokenSelectorScreen.tsx 6.50% <ø> (ø)
...nnectWallet/screens/Buy/fiat/FiatScreenContent.tsx 9.37% <0.00%> (ø)
packages/thirdweb/src/react/web/utils/errors.ts 5.26% <0.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joaquim-verges joaquim-verges merged commit 7684b76 into main Apr 29, 2025
25 of 26 checks passed
@joaquim-verges joaquim-verges deleted the _PayEmbed_Change_pay_with_a_debit_card_to_pay_with_card_ branch April 29, 2025 21:36
@joaquim-verges joaquim-verges mentioned this pull request Apr 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MananTank MananTank MananTank approved these changes

Assignees

@joaquim-verges joaquim-verges

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joaquim-verges @MananTank